-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1180): Mockup UI for Deployment and Revisions #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
0c09377 to
176ff05
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.49% (-0.11% 🔻) |
502/11192 |
| 🔴 | Branches | 3.65% (-0.05% 🔻) |
285/7805 |
| 🔴 | Functions | 2.54% (-0.08% 🔻) |
90/3543 |
| 🔴 | Lines | 4.45% (-0.11% 🔻) |
488/10959 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / DeploymentCreatePage.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / DeploymentListPage.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / DeploymentDetailPage.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / RevisionCreatePage.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / RevisionDetailPage.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / DeploymentCreateModal.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / DeploymentList.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / DeploymentModeTag.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / DeploymentStatusTag.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / TrafficRatioSlider.tsx |
0% | 0% | 0% | 0% |
Test suite run success
114 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from aee2be0
a0a1084 to
cc95ea0
Compare
3e99110 to
4beae81
Compare
4beae81 to
841aace
Compare
841aace to
b910aca
Compare
a905a38 to
a4387ed
Compare
feb2175 to
b69149c
Compare
8cad22d to
484babf
Compare
484babf to
8619c7b
Compare
b69149c to
1c0d578
Compare
8619c7b to
c5bcbf9
Compare
1c0d578 to
51cd3c7
Compare
51cd3c7 to
8d388c9
Compare
c5bcbf9 to
a2a70f9
Compare
8d388c9 to
108e579
Compare
108e579 to
aee2be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive Deployment Management UI to the WebUI, allowing users to create and manage model deployments with both simple preset-based configurations and expert mode with full control. The implementation includes list, detail, and creation pages for deployments and revisions with features like traffic ratio management and autoscaling rules.
- Adds new deployment management pages with CRUD operations for deployments and revisions
- Implements two deployment modes: simple (preset-based) and expert (full configuration)
- Includes traffic ratio management between deployment revisions
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/backend-ai-webui.ts | Adds 'deployment' to available pages list |
| src/backend-ai-app.ts | Adds deployment route handling and import |
| resources/i18n/en.json | Adds comprehensive i18n strings for deployment and revision features |
| react/src/pages/Deployments/*.tsx | Core deployment management pages with list, detail, and creation functionality |
| react/src/components/Deployments/*.tsx | Reusable deployment UI components for status, mode, traffic management |
| react/src/components/MainLayout/WebUISider.tsx | Adds deployment menu item to sidebar navigation |
| react/src/App.tsx | Defines React router configuration for deployment pages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| key: 'metricSource', | ||
| }, | ||
| { | ||
| title: t('revision.Condition'), |
Copilot
AI
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation key 'revision.Condition' is used but not defined in the i18n file. This will result in missing translation text.
| render: (_, row) => ( | ||
| <BAIFlex direction="row" gap="xs"> | ||
| <ResourceNumber type="cpu" value={row.total_cpu.toString()} /> | ||
| <ResourceNumber type="mem" value={'12g'} /> |
Copilot
AI
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded memory value '12g' should use actual data from the deployment object. Consider using row.total_mem or calculating from available data.
| <ResourceNumber type="mem" value={'12g'} /> | |
| <ResourceNumber type="mem" value={row.total_mem.toString()} /> |

resolves #3880 (FR-1180)
Add Deployment Management UI
This PR adds a new Deployment Management UI to the WebUI, allowing users to create and manage model deployments. The implementation includes:
The UI supports both simple preset-based deployments and expert mode with full configuration control.
Checklist: